diff options
| -rw-r--r-- | btasktd.c | 6 | ||||
| -rw-r--r-- | cliflags.c | 2 | ||||
| -rw-r--r-- | db.c | 4 |
3 files changed, 6 insertions, 6 deletions
@@ -83,7 +83,7 @@ main(int argc, char **argv) } show_help = extract_bool_flag('h', argc, argv); - if (show_help.code == fvr_ok && show_help.data) { + if (fvr_ok == show_help.code && show_help.data) { fprint_help(stdout); return 0; } @@ -100,7 +100,7 @@ main(int argc, char **argv) break; case fvr_ok: port = int_res.data; - if (port > 0) + if (port < 0) break; /* fallthrough */ case fvr_invalid: @@ -121,7 +121,7 @@ main(int argc, char **argv) break; case fvr_ok: users_cnt = int_res.data; - if (users_cnt > 0) + if (users_cnt <= 0) break; /* fallthrough */ case fvr_invalid: @@ -64,7 +64,7 @@ extract_str_flag(char flagletter, int argc, char **argv) for (i = 1; i < argc; i++) if (0 == strcmp(flagstr, argv[i])) break; - if (argc <= i) { + if (i >= argc) { res.code = fvr_not_found; } else if (argc-1 == i) { res.code = fvr_invalid; @@ -102,7 +102,7 @@ make_dir_ifne(const char *path, int rights) else if (val.data) return dbe_ok; code = mkdir(path, rights); - if (code != 0) { + if (0 != code) { if (EACCES == errno) return dbe_access; else if (EEXIST == errno) @@ -117,7 +117,7 @@ do_make_dir_path(const char *path, int rights) char buf[DIR_NAME_BUF_SIZE] = {0}; const char *p = find_chr_or_zero(path, '/'); unsigned sz = p - path + 1, code; - if (sizeof(buf) < sz) + if (sz > sizeof(buf)) return dbe_inval; strncpy(buf, path, sz); buf[sz-1] = '\0'; |